List batch messages takes query parameter #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2023
dmccartney
reviewed
Jul 18, 2023
This reverts commit a31935a.
nplasterer
commented
Jul 21, 2023
Comment on lines
+1
to
+5
| export type Query = { | ||
| startTime?: Date | undefined; | ||
| endTime?: Date | undefined; | ||
| contentTopic: string; | ||
| pageSize?: number | undefined; |
There was a problem hiding this comment.
This type matches the JS type.
Comment on lines
+201
to
+217
| AsyncFunction("loadMessages") { clientAddress: String, topic: String, limit: Int?, before: Long?, after: Long? -> | ||
| logV("loadMessages") | ||
| val client = clients[clientAddress] ?: throw XMTPException("No client") | ||
| val conversation = | ||
| findConversation( | ||
| clientAddress = clientAddress, | ||
| topic = topic, | ||
| ) ?: throw XMTPException("no conversation found for $topic") | ||
| val beforeDate = if (before != null) Date(before) else null | ||
| val afterDate = if (after != null) Date(after) else null | ||
|
|
||
| client.conversations.listBatchMessages(topics, limit, beforeDate, afterDate).map { | ||
| conversation.messages(limit = limit, before = beforeDate, after = afterDate) | ||
| .map { | ||
| EncodedMessageWrapper.encode(it) | ||
| } | ||
| } | ||
|
|
||
| AsyncFunction("loadBatchMessages") { clientAddress: String, topics: List<String> -> |
There was a problem hiding this comment.
loadMessages - lists all the messages via the envelopesList query inside of the SDKs
loadBatchMessages - lists all the messages for a batch of topics with given pagination parameters.
These are two different methods in the sdks and should be here as well. Previously both messages, and batch messages called the batch method.
nakajima
approved these changes
Jul 21, 2023
nplasterer
commented
Jul 21, 2023
Comment on lines
+118
to
+123
| return JSON.stringify({ | ||
| limit: item.pageSize || 0, | ||
| topic: item.contentTopic, | ||
| after: item.startTime?.getTime() || 0, | ||
| before: item.endTime?.getTime() || 0, | ||
| }); |
There was a problem hiding this comment.
This converts the javascript type to the JSON string that the SDKS expect.
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
This takes a list of query objects so each topic can have it's own pagination associated with it.
Matches the query type specified in
xmtp-jshttps://github.com/xmtp/xmtp-js/blob/main/src/ApiClient.ts#L56-L74Note: This is a breaking change.