Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve PreparedMessage handling #113

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat: improve PreparedMessage handling #113

merged 1 commit into from
Sep 6, 2023

Conversation

dmccartney
Copy link
Contributor

This refactors PreparedMessage to better support apps with robust pending queue architectures:

  • the PreparedMessage now contains the fully prepared envelopes
  • this adds reliable serialization methods to the PreparedMessage for persistence

This is the Android portion of xmtp/xmtp-react-native#82
See also xmtp/xmtp-ios#152

@dmccartney dmccartney requested a review from a team as a code owner September 6, 2023 21:16
@nplasterer
Copy link
Contributor

Looks like a couple of legit failures and lint issues. 👀

@dmccartney dmccartney merged commit 0976446 into main Sep 6, 2023
6 checks passed
@dmccartney dmccartney deleted the daniel-prep-message branch September 6, 2023 22:45
@dmccartney dmccartney mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmccartney @nplasterer