(closes #35) Changes for jax-metal #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new implementation of top_k is enabled with a flag. It should check the current device and use jax.lax.top_k if not running on jax-metal. This is not a general-purpose implementation of top_k but hopefully sufficient for sampling.
|
Added conditionals based on jax.extended.backend.get_backend(). Added jax-metal to toml. Verified that it is running on both Metal and CPU. In PR #57 |
|
i think the 'frog' branch needs to be merged into main to see if this implementing works with the new structure or not. |
|
I still don't know how to push updates to this branch so I am continuing with the "frog" integration in my version (pr-57). |
nix
changed the title
|
With all the jit annotations commented out, this jax-metal version is about 10x slower than the native MLX version: https://github.com/samefarrar/entropix_mlx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes to get jax working with metal: