Skip to content

Commit

Permalink
Update API version numbers and ABI dumps
Browse files Browse the repository at this point in the history
  • Loading branch information
ktmf01 committed Aug 7, 2023
1 parent c1fc2c9 commit 526f351
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/distcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
run: |
make
unxz --keep test/abi/abi-libFLAC-1.4.0.dump.xz
unxz --keep test/abi/abi-libFLAC++-1.4.0.dump.xz
abi-compliance-checker -l flac -old test/abi/abi-libFLAC-1.4.0.dump -new test/abi/abi-descriptor-libFLAC-1.4.3.xml
abi-compliance-checker -l flac++ -old test/abi/abi-libFLAC++-1.4.0.dump -new test/abi/abi-descriptor-libFLAC++-1.4.3.xml
unxz --keep test/abi/abi-libFLAC++-1.4.4.dump.xz
abi-compliance-checker -l flac -old test/abi/abi-libFLAC-1.4.0.dump -new test/abi/abi-descriptor-libFLAC-1.4.4.xml
abi-compliance-checker -l flac++ -old test/abi/abi-libFLAC++-1.4.4.dump -new test/abi/abi-descriptor-libFLAC++-1.4.4.xml
- name: Check with flac test files
run: ./src/flac/flac -t test-files/subset/*.flac test-files/uncommon/0[5-9]*.flac test-files/uncommon/10*.flac
Expand Down
4 changes: 2 additions & 2 deletions include/FLAC++/export.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
/** These \#defines will mirror the libtool-based library version number, see
* http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning
*/
#define FLACPP_API_VERSION_CURRENT 10
#define FLACPP_API_VERSION_REVISION 1 /**< see above */
#define FLACPP_API_VERSION_CURRENT 11
#define FLACPP_API_VERSION_REVISION 0 /**< see above */
#define FLACPP_API_VERSION_AGE 0 /**< see above */

/* \} */
Expand Down
4 changes: 2 additions & 2 deletions include/FLAC/export.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@
/** These \#defines will mirror the libtool-based library version number, see
* http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning
*/
#define FLAC_API_VERSION_CURRENT 13
#define FLAC_API_VERSION_CURRENT 14
#define FLAC_API_VERSION_REVISION 0 /**< see above */
#define FLAC_API_VERSION_AGE 1 /**< see above */
#define FLAC_API_VERSION_AGE 2 /**< see above */

#ifdef __cplusplus
extern "C" {
Expand Down
4 changes: 2 additions & 2 deletions src/libFLAC++/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ target_include_directories(FLAC++ INTERFACE
target_link_libraries(FLAC++ PUBLIC FLAC)
if(BUILD_SHARED_LIBS)
set_target_properties(FLAC++ PROPERTIES
VERSION 10.0.1
SOVERSION 10)
VERSION 11.0.0
SOVERSION 11)
if(NOT WIN32)
set_target_properties(FLAC++ PROPERTIES CXX_VISIBILITY_PRESET hidden)
endif()
Expand Down
2 changes: 1 addition & 1 deletion src/libFLAC++/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ endif
endif

# see 'http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning' for numbering convention
libFLAC___la_LDFLAGS = $(AM_LDFLAGS) -no-undefined -version-info 10:1:0 $(windows_resource_link)
libFLAC___la_LDFLAGS = $(AM_LDFLAGS) -no-undefined -version-info 11:0:0 $(windows_resource_link)
libFLAC___la_LIBADD = ../libFLAC/libFLAC.la
libFLAC___la_SOURCES = $(libFLAC___sources)

Expand Down
2 changes: 1 addition & 1 deletion src/libFLAC/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ if(TARGET Ogg::ogg)
endif()
if(BUILD_SHARED_LIBS)
set_target_properties(FLAC PROPERTIES
VERSION 12.1.0
VERSION 12.2.0
SOVERSION 12)
if(NOT WIN32)
set_target_properties(FLAC PROPERTIES C_VISIBILITY_PRESET hidden)
Expand Down
2 changes: 1 addition & 1 deletion src/libFLAC/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ extra_ogg_sources = \
endif

# see 'http://www.gnu.org/software/libtool/manual/libtool.html#Libtool-versioning' for numbering convention
libFLAC_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined -version-info 13:0:1 $(windows_resource_link)
libFLAC_la_LDFLAGS = $(AM_LDFLAGS) -no-undefined -version-info 14:0:2 $(windows_resource_link)

libFLAC_sources = \
bitmath.c \
Expand Down
4 changes: 4 additions & 0 deletions test/abi/README
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Dumps are created with for example
abi-compliance-checker -lib flac++ -dump test/abi/abi-descriptor-libFLAC++-x.y.z.xml -dump-path test/abi/abi-libFLAC++-x.y.z.dump

not with abi-dumper
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
</headers>

<libs>
src/libFLAC++/.libs/libFLAC++.so.10.0.1
src/libFLAC++/.libs/libFLAC++.so.11.0.0
</libs>
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
</headers>

<libs>
src/libFLAC/.libs/libFLAC.so.12.1.0
src/libFLAC/.libs/libFLAC.so.12.2.0
</libs>
Binary file removed test/abi/abi-libFLAC++-1.4.0.dump.xz
Binary file not shown.
Binary file added test/abi/abi-libFLAC++-1.4.4.dump.xz
Binary file not shown.

0 comments on commit 526f351

Please sign in to comment.