Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable Regexpr Engine #315

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pluggable Regexpr Engine #315

wants to merge 3 commits into from

Conversation

whitingj
Copy link

@whitingj whitingj commented Sep 2, 2020

Adding support for plugging in different regular expression engines.

Anything that implements the RegexpProvider interface can be used in to do all the regexp matching. I'm not sold on the name of the interface or the name of the property in SchemaLoader, so I'm happy to take suggestions on the name.

I added new tests for the functionality and verified that all the line I changed have test coverage.

Let me know what you think.

P.S. Sorry there is a little bit of noise in README.md as my editor striped trailing whitespace.

@whitingj
Copy link
Author

whitingj commented Sep 2, 2020

My hope is that by getting this into gojsonschema we can close out all the regexp issues and allow people to use whatever regex engine they want. FWIW, I agree that it should default to using golang's regexp while giving flexibility.

@whitingj
Copy link
Author

whitingj commented Sep 4, 2020

@johandorland it would be great to get you to review this change.

This would close issues #277, #232.

@cndoit18
Copy link

@johandorland I think we may need this support. Can you help to review this? please

@Surfoo
Copy link

Surfoo commented Oct 26, 2022

Hello,
This repository is not maintained anymore, the new one is https://github.com/gojsonschema/gojsonschema, could you submit your PR on this one? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants