-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unocss module #1043
base: main
Are you sure you want to change the base?
feat: unocss module #1043
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 82.07% 82.13% +0.06%
==========================================
Files 127 127
Lines 6661 6661
Branches 1112 1112
==========================================
+ Hits 5467 5471 +4
+ Misses 1180 1176 -4
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@Timeraa I made some changes to simplify things:
There isn't unfortunately :/. I see the warning you're talking about, don't know how to remove it.
I think leaving it as optional is fine. I added a default of I have plans to clean up Vite's logs in general, after that it should be possible to improve the warning message and tell them to add the entrypoint to |
Ignore the failing |
Everything looks fine to me! |
This PR should make the use of unocss with WXT a fair share easier, see reference issues: #522 #1026
Makes the need for this obsolete: #596
@aklinker1 Any way we can have the
vite:devServer:extendConfig
have entrypoints as well because then I can get rid of the "Entry module not found." warning you will get when it runs over entrypoints you don't want to use.Also I am a bit uncertain but I think that
unocss.entrypoints
should be required so that you don't run it on files where it's not used, what's your opinion?