Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null property being added to external claims #6061

Merged

Conversation

amanda-ariyaratne
Copy link
Contributor

Proposed changes in this pull request

If an external claim has no properties (null, null) is added to the property hash map of the claim. It is fixed by this PR.

Copy link

sonarcloud bot commented Oct 25, 2024

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11513262433

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.07%. Comparing base (834a75d) to head (9501a31).
Report is 161 commits behind head on master.

Files with missing lines Patch % Lines
...ntity/claim/metadata/mgt/dao/ExternalClaimDAO.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6061      +/-   ##
============================================
- Coverage     40.42%   40.07%   -0.35%     
+ Complexity    14625    14324     -301     
============================================
  Files          1745     1746       +1     
  Lines        122321   118531    -3790     
  Branches      21640    20474    -1166     
============================================
- Hits          49447    47501    -1946     
+ Misses        65365    63727    -1638     
+ Partials       7509     7303     -206     
Flag Coverage Δ
unit 24.48% <50.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11513262433
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11513262433

@amanda-ariyaratne amanda-ariyaratne merged commit e45006f into wso2:master Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants