Add displayName method for Action Execution enum #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashanthamara
previously approved these changes
Oct 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6056 +/- ##
=========================================
Coverage 40.24% 40.25%
- Complexity 14338 14340 +2
=========================================
Files 1746 1746
Lines 118245 118269 +24
Branches 19220 19225 +5
=========================================
+ Hits 47590 47604 +14
- Misses 63338 63346 +8
- Partials 7317 7319 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
malithie
reviewed
Oct 24, 2024
|
|
||
| public String getDisplayName() { | ||
|
|
||
| return Action.ActionTypes.valueOf(this.value).getDisplayName(); |
There was a problem hiding this comment.
we don't need this string instance variable right ? why not just use this.name()
There was a problem hiding this comment.
Updated in 7628689
|
malithie
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this PR
This PR adds a displayName method for ActionType enum in action execution component
Related Issues
process-action-responseaction id in diagnostics logs product-is#21474