-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying keystore related functionalities into one place #6028
Conversation
911254f
to
cca1bc9
Compare
9be0b9a
to
9293082
Compare
...urity.mgt/src/main/java/org/wso2/carbon/security/keystore/KeyStoreManagementServiceImpl.java
Show resolved
Hide resolved
...ty.mgt/src/main/java/org/wso2/carbon/security/keystore/service/KeyStoreAdminServiceImpl.java
Show resolved
Hide resolved
PR builder started |
PR builder completed |
f975588
to
3859a3d
Compare
PR builder started |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6028 +/- ##
============================================
+ Coverage 40.18% 40.43% +0.24%
- Complexity 14180 14687 +507
============================================
Files 1736 1746 +10
Lines 116908 123017 +6109
Branches 20125 21841 +1716
============================================
+ Hits 46981 49736 +2755
- Misses 62710 65716 +3006
- Partials 7217 7565 +348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11504516870
b8483b7
to
82fc476
Compare
...2.carbon.security.mgt/src/test/java/org/wso2/carbon/security/keystore/KeyStoreAdminTest.java
Outdated
Show resolved
Hide resolved
...2.carbon.security.mgt/src/test/java/org/wso2/carbon/security/keystore/KeyStoreAdminTest.java
Show resolved
Hide resolved
...2.carbon.security.mgt/src/test/java/org/wso2/carbon/security/keystore/KeyStoreAdminTest.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Proposed changes in this pull request
Improve KeyStoreAdmin Class to Utilize Kernel KeyStore Functionalities
When should this PR be merged
After