Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying keystore related functionalities into one place #6028

Merged
merged 14 commits into from
Oct 25, 2024

Conversation

hwupathum
Copy link
Contributor

@hwupathum hwupathum commented Oct 15, 2024

Proposed changes in this pull request

Improve KeyStoreAdmin Class to Utilize Kernel KeyStore Functionalities

  • Refactored the KeyStoreAdmin class to leverage keystore functionalities in the kernel.
  • Removed direct registry usage for cleaner and more maintainable code.

When should this PR be merged

After

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11504224728

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11504224728
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11504516870

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 15.68627% with 43 lines in your changes missing coverage. Please review.

Project coverage is 40.43%. Comparing base (3818818) to head (565230f).
Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/security/keystore/KeyStoreAdmin.java 22.85% 27 Missing ⚠️
...ity/keystore/service/KeyStoreAdminServiceImpl.java 0.00% 12 Missing ⚠️
...curity/keystore/KeyStoreManagementServiceImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6028      +/-   ##
============================================
+ Coverage     40.18%   40.43%   +0.24%     
- Complexity    14180    14687     +507     
============================================
  Files          1736     1746      +10     
  Lines        116908   123017    +6109     
  Branches      20125    21841    +1716     
============================================
+ Hits          46981    49736    +2755     
- Misses        62710    65716    +3006     
- Partials       7217     7565     +348     
Flag Coverage Δ
unit 24.48% <15.68%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11504516870
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11504516870

Copy link

sonarcloud bot commented Oct 25, 2024

@UdeshAthukorala UdeshAthukorala merged commit b6ef275 into wso2:master Oct 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants