Add support to connect to the LoginFlow AI service #5971

sahandilshan · 2024-09-30T10:27:50Z

Proposed changes in this pull request

With this PR, the product-is will be able to connect the loginflow AI microservice and generate AI results accordingly

Related Issue(s)

AI-Powered Login Flow feature product-is#20040

CLAassistant · 2024-09-30T10:27:55Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java

...n.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAITokenService.java

sonarcloud · 2024-10-18T08:39:55Z

Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

pamodaaw · 2024-10-18T08:44:09Z

...cation.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManager.java

@@ -0,0 +1,23 @@
+package org.wso2.carbon.identity.application.mgt.ai;


missing copywrite text

pamodaaw · 2024-10-18T08:54:23Z

features/ai-services-mgt/pom.xml

+        <module>org.wso2.carbon.ai.service.mgt.server.feature</module>
+    </modules>
+
+</project>


Missing new line

pamodaaw · 2024-10-18T08:54:59Z

features/ai-services-mgt/pom.xml

+
+    <artifactId>ai-services-mgt-feature</artifactId>
+    <packaging>pom</packaging>
+    <name>WSO2 Carbon - API Resource Management Feature</name>


Is this name correct

pamodaaw · 2024-10-18T08:58:03Z

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml

+                <version>${maven.surefire.plugin.version}</version>
+                <configuration>
+                    <!--suppress UnresolvedMavenProperty -->
+                    <argLine>


Why these are added?

codecov · 2024-10-18T08:59:44Z

Codecov Report

Attention: Patch coverage is 50.84746% with 116 lines in your changes missing coverage. Please review.

Project coverage is 40.19%. Comparing base (1608510) to head (ddfaf3c).
Report is 39 commits behind head on master.

Files with missing lines	Patch %	Lines
...2/carbon/ai/service/mgt/util/AIHttpClientUtil.java	49.29%	30 Missing and 6 partials ⚠️
...bon/ai/service/mgt/token/AIAccessTokenManager.java	71.26%	20 Missing and 5 partials ⚠️
...ity/application/mgt/ai/LoginFlowAIManagerImpl.java	0.00%	19 Missing ⚠️
...lication/mgt/ai/constant/LoginFlowAIConstants.java	0.00%	17 Missing ⚠️
...n/ai/service/mgt/exceptions/AIClientException.java	33.33%	8 Missing ⚠️
...n/ai/service/mgt/exceptions/AIServerException.java	50.00%	7 Missing ⚠️
...2/carbon/ai/service/mgt/constants/AIConstants.java	80.00%	3 Missing ⚠️
...nternal/ApplicationManagementServiceComponent.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5971      +/-   ##
============================================
- Coverage     40.33%   40.19%   -0.15%     
+ Complexity    14346    14217     -129     
============================================
  Files          1739     1747       +8     
  Lines        119425   117361    -2064     
  Branches      20773    20168     -605     
============================================
- Hits          48167    47170     -997     
+ Misses        63917    62957     -960     
+ Partials       7341     7234     -107

Flag	Coverage Δ
unit	`24.04% <50.84%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pamodaaw · 2024-10-18T09:00:18Z

features/ai-services-mgt/org.wso2.carbon.ai.service.mgt.server.feature/pom.xml

+        </plugins>
+    </build>
+
+</project>


missing new line

pamodaaw · 2024-10-18T09:01:41Z

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java

+
+    @Test
+    public void testGetAuthenticationSequenceGenerationStatus_Success() throws Exception {
+        Map<String, Object> response = new HashMap<>();


missing new line

pamodaaw · 2024-10-18T09:02:11Z

...on.mgt/src/test/java/org/wso2/carbon/identity/application/mgt/ai/LoginFlowAIManagerTest.java

+import static org.wso2.carbon.base.MultitenantConstants.SUPER_TENANT_DOMAIN_NAME;
+import static org.wso2.carbon.base.MultitenantConstants.SUPER_TENANT_ID;
+
+public class LoginFlowAIManagerTest {


Class description missing

pamodaaw · 2024-10-18T09:02:46Z

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java

+        SERVER_ERROR_WHILE_CONNECTING_TO_LOGINFLOW_AI_SERVICE("AILF_10009", "Server error occurred " +
+                "for %s tenant while generating authentication sequence.");
+
+


extra new line

pamodaaw · 2024-10-18T09:04:22Z

components/ai-services-mgt/org.wso2.carbon.ai.service.mgt/pom.xml

+                                        <limit implementation="org.jacoco.report.check.Limit">
+                                            <counter>COMPLEXITY</counter>
+                                            <value>COVEREDRATIO</value>
+                                            <minimum>0.50</minimum>


This test coverage threshold is not enough.

pamodaaw · 2024-10-18T09:05:11Z

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java

+        MAXIMUM_RETRIES_EXCEEDED("AI_10000", "Maximum retries exceeded to retrieve the access token."),
+        UNABLE_TO_ACCESS_AI_SERVICE_WITH_RENEW_ACCESS_TOKEN("AI_10003", "Unable to access the " +


Let's make the error codes in consistent oreder

pamodaaw · 2024-10-18T09:06:34Z

...arbon.ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/constants/AIConstants.java

+                "for %s tenant while connecting to AI service."),
+        SERVER_ERROR_WHILE_CONNECTING_TO_AI_SERVICE("AI_10009", "Server error occurred " +
+                "for %s tenant while connecting to AI service.");
+


extra new line

pamodaaw · 2024-10-18T09:12:34Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                        public void completed(HttpResponse response) {
+
+                            try {
+                                if (response.getStatusLine().getStatusCode() == HttpStatus.SC_OK) {


is this line null safe?

pamodaaw · 2024-10-18T09:14:02Z

....ai.service.mgt/src/main/java/org/wso2/carbon/ai/service/mgt/token/AIAccessTokenManager.java

+                    }
+                }
+            } catch (IOException e) {
+                throw new AIServerException("Failed to close HTTP client: " + e.getMessage(), e);


Is this error message correct?

Add support to connect to the LoginFlow AI service

e73a82c

sahandilshan force-pushed the loginflow-ai branch from ec247a1 to e73a82c Compare October 3, 2024 11:39

sahandilshan mentioned this pull request Oct 6, 2024

Add api support to try out loginglow AI feature wso2/identity-api-server#681

Open

pamodaaw reviewed Oct 7, 2024

View reviewed changes

components/application-mgt/org.wso2.carbon.identity.application.mgt/pom.xml Show resolved Hide resolved

pamodaaw reviewed Oct 7, 2024

View reviewed changes

...src/main/java/org/wso2/carbon/identity/application/mgt/ai/constant/LoginFlowAIConstants.java Show resolved Hide resolved

pamodaaw reviewed Oct 7, 2024

View reviewed changes

sahandilshan added 6 commits October 18, 2024 12:23

Add AI Management component

2c24dee

Add ai feature component

22bcf9b

Add loginflow AI capability

3532bd4

Merge remote-tracking branch 'upstream/master' into loginflow-ai-2

c3431ee

Bump new component version

2df174b

Fix code quality

5367ae1

sahandilshan force-pushed the loginflow-ai branch from 8ee9876 to 5367ae1 Compare October 18, 2024 08:32

Bump AI version to latest framework version

ddfaf3c

pamodaaw reviewed Oct 18, 2024

View reviewed changes

features/ai-services-mgt/org.wso2.carbon.ai.service.mgt.server.feature/pom.xml

</plugins>

</build>

</project>

Copy link

Contributor

pamodaaw Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

pamodaaw reviewed Oct 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to connect to the LoginFlow AI service #5971

Add support to connect to the LoginFlow AI service #5971

sahandilshan commented Sep 30, 2024

CLAassistant commented Sep 30, 2024

sonarcloud bot commented Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

codecov bot commented Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

pamodaaw Oct 18, 2024

		@@ -0,0 +1,23 @@
		package org.wso2.carbon.identity.application.mgt.ai;

		SERVER_ERROR_WHILE_CONNECTING_TO_LOGINFLOW_AI_SERVICE("AILF_10009", "Server error occurred " +
		"for %s tenant while generating authentication sequence.");

		MAXIMUM_RETRIES_EXCEEDED("AI_10000", "Maximum retries exceeded to retrieve the access token."),
		UNABLE_TO_ACCESS_AI_SERVICE_WITH_RENEW_ACCESS_TOKEN("AI_10003", "Unable to access the " +

Add support to connect to the LoginFlow AI service #5971

Are you sure you want to change the base?

Add support to connect to the LoginFlow AI service #5971

Conversation

sahandilshan commented Sep 30, 2024

Proposed changes in this pull request

Related Issue(s)

CLAassistant commented Sep 30, 2024

sonarcloud bot commented Oct 18, 2024

Quality Gate passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 18, 2024

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment