Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+5 −1
Open

Fixes #7042 Argument 2 ($url) passed to exclude_rocket_from_wp_updates() must be of the type string #7059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16999e
:closes: #7042 Revert phpstand update on wp_updates method
Khadreal Oct 25, 2024
68df013
Fix lint
Khadreal Oct 25, 2024
92464d1
Add phpstan ignore line
Miraeld Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion inc/Engine/Plugin/UpdaterSubscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,11 @@ public static function get_subscribed_events() {
* @param string $url The request URL.
* @return array Updated array of HTTP request arguments.
*/
public function exclude_rocket_from_wp_updates( $request, string $url ) {
public function exclude_rocket_from_wp_updates( $request, $url ) {
if ( ! is_string( $url ) ) { // @phpstan-ignore-line GH #7042 - $url variable may be change by other plugins to something else than string.
return $request;
}

if ( ! preg_match( '@^https?://api.wordpress.org/plugins/update-check(/|\?|$)@', $url ) || empty( $request['body']['plugins'] ) ) {
// Not a plugin update request. Stop immediately.
return $request;
Expand Down
Loading