Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7038 Activate minification by default #7052

Open
wants to merge 2 commits into
base: feature/3.18
Choose a base branch
from

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Oct 22, 2024

Description

Fixes #7038
Activate minification by default.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check EPIC Card

Technical description

Change the value of minify_css/js to 1 to activate it by default.

Documentation

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal self-assigned this Oct 22, 2024
@Khadreal Khadreal marked this pull request as ready for review October 22, 2024 17:51
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 815e6391 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (815e639) Report Missing Report Missing Report Missing
Head commit (b534476) 37750 16597 43.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7052) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal requested a review from a team October 22, 2024 17:51
@Miraeld
Copy link
Contributor

Miraeld commented Oct 23, 2024

I'm approving the change as it's ok for me. However,
This is a 3.18 feature, should we merge it onto develop or a 3.18 branch ?

@remyperona
Copy link
Contributor

We should create a branch-3.18 and merge it in it for now

@Miraeld Miraeld changed the base branch from develop to feature/3.18 October 24, 2024 11:06
@Miraeld
Copy link
Contributor

Miraeld commented Oct 24, 2024

Created a feature/3.18 branch and rebased this PR on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate Minification by default
3 participants