Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined WPR_WEBP env var #5562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dvershinin
Copy link

Improves readability of .htaccess by preventing the inclusion of undefined WPR_WEBP environment variable when WebP caching is disabled.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • [x ] New and existing unit tests pass locally with my changes

Co-authored-by: Roy Orbitson <Roy-Orbison@users.noreply.github.com>
@dvershinin
Copy link
Author

@Roy-Orbison updated with the suggestion and squashed it into a single commit.

@dvershinin
Copy link
Author

@Roy-Orbison can we have this merged now? Thank you in advance :-)

@Roy-Orbison
Copy link

@dvershinin I don't work for them, sorry. I just read your commit when I was doing one myself (#6123).

@dvershinin
Copy link
Author

Oh, I see. @engahmeds3ed would you take a look, please? We're working on a converter for Apache configurations, and this is one of the issues somewhat critical for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants