Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[640][WFLY-19866] Add an analysis document for promoting the MicroPro… #641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Oct 18, 2024

…file REST Client 4.0 API from preview to default.

resolves #640

…file REST Client 4.0 API from preview to default.

Signed-off-by: James R. Perkins <jperkins@redhat.com>
@github-actions github-actions bot added the stability-level/default "Default" stability-level label Oct 18, 2024
@jamezp jamezp marked this pull request as ready for review October 18, 2024 20:31

=== User Stories

A user wants to use the MicroProfile REST Client version 4.0 or use MicroProfile Platform 7.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate how users can benefit from new features brought by new REST Client?

from a stability level of `preview` to a stability level of `default`.

As you'll see in the release notes below, not much was added to the MicroProfile REST Client 4.0 API. There are only two
new methods added to the `RestClientBuilder` API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://microprofile.io/specifications/rest-client/4-0/

What about There was a clarification about closing the REST client when being injected via CDI? Is there some change in our implementation because of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is no change in our implementation for that. This was changed in resteasy-microprofile in resteasy/resteasy-microprofile#50. This issue arrived because of this fix.

There would be no changes to security considerations for this upgrade.

[[test_plan]]
== Test Plan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezp Can you please update this section based on the template?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure what is needed TBH. We don't really have any tests in WildFly short of the TCK and other tests using the MP REST Client.

There is no subsystem configuration or anything. Do we want to add a bunch of tests? If we do, that might take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability-level/default "Default" stability-level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote MicroProfile REST Client from preview to default stability
2 participants