Updating postConfigure()

[atef23]

Updating postConfigure to check if delayedpostconfigure.sh is present and execute it if present. Otherwise check if postconfigure.sh is present and execute it.

Hi,

The launch scripts for container images call postConfigure. Currently, if there is no delayedpostconfigure.sh present under $JBOSS_HOME/extensions then postconfigure.sh does not get invoked even it is there. I observed this behavior in the kieserver-rhel8 image:

https://catalog.redhat.com/software/containers/rhpam-7/rhpam-kieserver-rhel8/5db03b6cbed8bd164af2a202?container-tabs=dockerfile

The SSO image script does not have a delayed post configure but does directly call postconfigure. A colleague of mine was able to invoke postconfigure.sh by placing it under /opt/eap/extensions on a container running the SSO image. When I attempted to deploy the kieserver-rhel8 image, I needed to add an empty placeholder delayedpostconfigure.sh to get postconfigure.sh to execute. I'm not sure what the intent is, but please let me know if I can help with any modifications.

Thanks.

[atef23]

I'm not sure if the intent is to check for delayedpostconfigure.sh and execute that instead of postconfigure.sh or to execute both if they are present. I don't see the delayedpostconfigure.sh function called:

https://github.com/jboss-container-images/jboss-kie-modules/blob/283e0d3f077d9aa3968f36a55762e6a0102715ab/jboss-kie-smartrouter/added/launch/configure.sh

https://github.com/jboss-container-images/jboss-kie-modules/blob/283e0d3f077d9aa3968f36a55762e6a0102715ab/os-eap-legacy/os-eap-launch/added/launch/configure.sh

https://github.com/jboss-container-images/jboss-kie-modules/blob/283e0d3f077d9aa3968f36a55762e6a0102715ab/jboss-kie-process-migration/added/launch/configure.sh

So I assumed delayedpostconfigure.sh should be executed through a call to the postConfigure function

[jfdenise]

@atef23 in EAP and WildFly images we are calling delayedPostConfigure that calls postconfigure.sh script if delayedpostconfigure.sh is not present. That is done there: https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/container/wildfly/launch-config/config/added/launch/launch.sh#L87
I suspect your images are not using the same entry point.
So we can't integrate your PR in the master branch, it would break WildFly images. We need to understand your setup. Are you using a branch of wildfly-cekit-modules?

[atef23]

Ah I see. Let me try to find the upstream source for the kieserver-rhel8 image:

https://catalog.redhat.com/software/containers/rhpam-7/rhpam-kieserver-rhel8/5db03b6cbed8bd164af2a202?container-tabs=dockerfile

That is the one that is calling a configure.sh which I suspect is not calling delayedPostConfigure like one of those scripts I liked above. The workaround I'm using right now is to place an empty delayedPostConfigure.sh under /opt/eap/extensions along with a functional postConfigure.sh which causes the postConfigure.sh to get executed.