[WIP] Add ShellCheck to check all .sh, .bash, .bats files #227
Conversation
|
@jfdenise this can wait until after the next release IMO, but we should get it in right after that so we have some time to keep an eye on it. This only addresses the ShellCheck errors, so theres a few more things to look at later. Test run here: https://github.com/luck3y/wildfly-cekit-modules/actions/runs/688163867 |
|
@luck3y , this seems very good to me. All these changes have been applied automatically by some tooling? Shouldn't we merge this asap and enable the checker job? BTW, we also have scripts in other repos that coud benefit from this check. |
|
@jfdenise This is a combination of (for example):
and some manual changes that shellcheck can't patch automatically. I agree that it appears fine, the only reason I suggest waiting until the next (minor) release is that it could introduce new issues and thats a slight risk -- but the tests passing suggest that perhaps it would be ok. I'm fine with either doing it now or waiting, thats why I asked you :) |
|
and +1 to the other repos, I was planning on doing this for jboss-eap-modules as well. Do we have others? |
| logger_level=$(echo $logger | awk -F':' '{print $2}') | ||
| logger_category=$(echo "$logger" | awk -F':' '{print $1}') | ||
| logger_level=$(echo "$logger" | awk -F':' '{print $2}') | ||
| allowed_log_levels_str=$(printf ",%s", "${allowed_log_levels[@]}") |
There was a problem hiding this comment.
Note this is a manual change, converting an array to a string seperated with ','
| @@ -94,7 +94,7 @@ EOF | |||
| @test "Generate JGroups Auth config - missing cluster password" { | |||
| run generate_jgroups_auth_config "" "digest_algo" | |||
| echo "Result: ${output}" | |||
| [[ "${output}" =~ "No password defined for JGroups cluster." ]] | |||
| [[ "${output}" =~ .*"No password defined for JGroups cluster.".* ]] | |||
There was a problem hiding this comment.
These are changed manually as well to correct the behavior of =~ operating on a regex. The intent here is that the string contains the message, but does not necessarily match the message completly.
| @@ -195,8 +194,8 @@ EOF | |||
|
|
|||
| run configure_jgroups_encryption | |||
| echo "${output}" | |||
| [[ "${output}" =~ "INFO Configuring JGroups cluster traffic encryption protocol to SYM_ENCRYPT." ]] | |||
| [[ "${output}" =~ "WARN Detected missing JGroups encryption configuration, the communication within the cluster WILL NOT be encrypted." ]] | |||
| [[ "${output}" =~ .*"INFO Configuring JGroups cluster traffic encryption protocol to SYM_ENCRYPT.".* ]] | |||
There was a problem hiding this comment.
Same regex comment as above, I won't mention all of these, but something to be aware of.
No description provided.