add ability to specify a class for a stale connection

[hhellbusch]

for example - want the resulting datasource validations to look like -

<validation>
        <valid-connection-checker class-name="org.jboss.jca.adapters.jdbc.extensions.oracle.OracleValidConnectionChecker"/>
        <stale-connection-checker class-name="org.jboss.jca.adapters.jdbc.extensions.oracle.OracleStaleConnectionChecker"/>
        <exception-sorter class-name="org.jboss.jca.adapters.jdbc.extensions.oracle.OracleExceptionSorter"/>
    </validation>

[wildfly-ci]

Hello, hhellbusch. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

Available Commands:

/help Display this help text.

/ok-to-test Add the user to the approved list of testers and run tests.

/retest Rerun all tests.

[jfdenise]

Would you mind logging a CLOUD_XXX issue for this?
We have now a dual way of handling env var. sed patching and CLI operations sent to the server.

wildfly-cekit-modules/jboss/container/wildfly/launch/datasources/added/launch/datasource-common.sh

Line 549 in 9bdb4fe

if [ "$validate" == "true" ]; then

So you will need to update this part too.
We are also adding new env var to https://github.com/wildfly/wildfly-cekit-modules/blob/master/jboss/container/wildfly/launch/datasources/module.yaml for documentation purpose.

[hhellbusch]

Sorry, not sure where to create a CLOUD_XXX issue... Can you share the link? First time contributing here :)

[jfdenise]

Sure, you can log a JIRA using https://issues.jboss.org the project to log the issue against is Cloud Enablement. Then you can use the created CLOUD-XXX id in the commit description, for example: "Fix for CLOUD-XXX: add ability to specify a class for a stale connection"

[hhellbusch]

ticket has been opened -
https://issues.jboss.org/browse/CLOUD-3427

Cheers!

[hhellbusch]

@jfdenise i know its been a few years... is this PR still of use to ya'll? looks like the jira i opened never had any traction either.