Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-19790] Remove batch-processing DS file #960

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WFLY-19790] Remove batch-processing DS file #960

wants to merge 1 commit into from

Conversation

liweinan
Copy link
Contributor

@liweinan liweinan commented Sep 30, 2024 •
edited by emmartins
Loading

@liweinan liweinan changed the title WFLY-19790 Remove batch-processing DS file [WFLY-19790] Remove batch-processing DS file Sep 30, 2024
@liweinan
Copy link
Contributor Author

@jfdenise I don't know how to fix this error:

As the h2-database has already been added. Could you please help check this? Thanks!

@liweinan liweinan marked this pull request as draft October 1, 2024 15:15
emmartins
emmartins requested changes Oct 3, 2024
View reviewed changes
batch-processing/configure-server.cli
run-batch

# Reload the server configuration
#reload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the reload since that has troubles when executed in server provisioning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create another PR to do this if necessary.

@emmartins
Copy link
Contributor

Besides the script change, guess we need instructions wrt the script execution when used with bare-metal standard distribution, and a config restore script too? You can reuse content from

quickstart/ee-security/README-source.adoc

Line 40 in 484ba35

=== Configure the Server

@emmartins
Copy link
Contributor

Btw I really thought you would just need to update the persistence.xml, ie no need for config change script...
@scottmarlow I wonder if this (replace usage of the DS file with just persistence.xml) would be possible?

@liweinan
Copy link
Contributor Author

liweinan commented Oct 7, 2024 •
edited
Loading

@emmartins Thanks for checking this PR!

I discussed this issue with @jamezp, and the DS file may still be used in the future, so I am holding off on this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liweinan @emmartins