Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18768] OpenShift support for the mail quickstart #923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dkafetzis
Copy link

@Dkafetzis Dkafetzis requested a review from emmartins as a code owner May 31, 2024 10:26
Copy link

openshift-ci bot commented May 31, 2024

Hi @Dkafetzis. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@emmartins
Copy link
Contributor

hi @Dkafetzis , I am delegating review to @yersan , who leads mail's component

@yersan
Copy link
Contributor

yersan commented Jul 4, 2024

/ok-to-test

Copy link
Contributor

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Dkafetzis , you did great work with this, thanks!

I've added minor notes to review, also, when I compile the mail server locally, the readme.html generated does not contain all the steps related to helm charts and OpenShift, what is the trick to read the final documentation generated from this soruces?

== Deploy the {ProductShortName} Source-to-Image (S2I) Quickstart to OpenShift with Helm Charts

Log in to your OpenShift instance using the `oc login` command.
The backend will be built and deployed on OpenShift with a Helm Chart for {productName}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/The backend will be built and deployed/The application will be built and deployed

Named it backend here does not sound correct to me, it is not a backend that exposes any API to other front-end applications.

@@ -0,0 +1,22 @@
=== Install OpenTelemetry Collector on OpenShift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is not correct, it should be "Install the Mail server on Openshift" or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants