Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with image crate #9

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

Schmiddiii
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #9 (56f571c) into main (b02b2ec) will increase coverage by 1.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   86.42%   88.11%   +1.68%     
==========================================
  Files           6        6              
  Lines         221      244      +23     
==========================================
+ Hits          191      215      +24     
+ Misses         30       29       -1     
Files Changed Coverage Δ
src/lib.rs 95.83% <100.00%> (+1.61%) ⬆️

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added --all-features to the CI build, so if you could look after the change requests and then rebase, we can see it in action in CI!

src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last small thing!

src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@rubdos rubdos self-requested a review August 23, 2023 19:48
@rubdos rubdos merged commit 9ed0f0f into whisperfish:main Aug 23, 2023
7 checks passed
@Schmiddiii Schmiddiii deleted the image branch August 23, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants