Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up deps #4357

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-ads-compete.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wagmi/connectors": patch
---

Bumped dependencies.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@
"ignore": ["test/{constants,setup,utils}.ts"]
},
"packages/connectors": {
"entry": "src/exports/index.ts!",
"ignoreDependencies": ["@walletconnect/modal"]
"entry": "src/exports/index.ts!"
},
"packages/core": {
"entry": "src/exports/{actions,chains,codegen,experimental,index,internal,query}.ts!",
Expand Down
3 changes: 1 addition & 2 deletions packages/connectors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,11 @@
}
},
"dependencies": {
"@coinbase/wallet-sdk": "4.0.4",
"@coinbase/wallet-sdk": "4.1.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less deps than 4.0.4

4.0.4 4.1.0
001658_Firefox_2024-10-21-23 05 38@2x 001656_Firefox_2024-10-21-23 05 17@2x

"@metamask/sdk": "0.30.0",
"@safe-global/safe-apps-provider": "0.18.3",
"@safe-global/safe-apps-sdk": "9.1.0",
"@walletconnect/ethereum-provider": "2.17.0",
"@walletconnect/modal": "2.7.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included in "@walletconnect/ethereum-provider"

"cbw-sdk": "npm:@coinbase/wallet-sdk@3.9.3"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions packages/connectors/src/coinbaseWallet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,16 @@ function version4(parameters: Version4Parameters) {
async getAccounts() {
const provider = await this.getProvider()
return (
await provider.request<string[]>({
(await provider.request({
method: 'eth_accounts',
})
})) as string[]
).map((x) => getAddress(x))
},
async getChainId() {
const provider = await this.getProvider()
const chainId = await provider.request<Hex>({
const chainId = (await provider.request({
method: 'eth_chainId',
})
})) as Hex
return Number(chainId)
},
async getProvider() {
Expand Down
19 changes: 7 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading