[WIP] 117 generator #144
Closed
[WIP] 117 generator #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd appreciate some tests checking if generation works properly |
wende
reviewed
Jul 22, 2017
installer/.gitignore
Outdated
| # variables. | ||
| /config/prod.secret.exs | ||
|
|
||
| # -*- mode: gitignore; -*- |
There was a problem hiding this comment.
As far as I know Emacs mode should be at the first line to work properly
There was a problem hiding this comment.
:/ As far as I can remember its fresh elixir generated gitignor
wende
requested changes
Jul 22, 2017
wende
requested changes
Sep 1, 2017
| "exposed-modules": [], | ||
| "dependencies": { | ||
| "elm-lang/core": "5.1.1 <= v < 6.0.0", | ||
| "wende/elmchemy-core": "1.0.0 <= v < 2.0.0" |
There was a problem hiding this comment.
the correct one is "wende/elchemy-core": "0.0.0 <= v < 1.0.0"
But probably it'd be better to copy it entirely from the current /templates/elm-package.json
| @@ -0,0 +1,5 @@ | |||
| defmodule CharacterTest do | |||
| use ExUnit.Case | |||
| use Elmchemy | |||
There was a problem hiding this comment.
A good template for testing would be
defmodule <%= app_module %>Test do
use ExUnit.Case
use Elchemy
doctest <%= app_module %>
typetest <%= app_module %>
test do
assert <%= app_module %>.hello == "world"
end
end
|
@baransu Go ahead, I am dead out of time to work on it. I will be gratefull! |
|
Closing the PR till somebody picks it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step generator based on the one that phoenix have.
[WIP] - Please don't touch since a lot of things will chagne
/Edit wende: Closes #117