-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource control for webhook form action #4333
base: main
Are you sure you want to change the base?
Conversation
Ref #4093 #3871 Here added new resource control for out properties. It is replaced action and method properties webhook form. Now users will be able to additionally provide headers. In another PR headers will let user to customize body format. Also migrated "action" in existing webhook forms to resource prop type.
Haven't tested, but looks great, lets list what this enables from use cases perspective, so that once @johnsicili is back we can record an edu video, maybe replacing the old form video. Are all of these done? #4093 |
So far I see 2 use cases we need to demonstrate:
Am I correct to assume both use cases are supported now? |
In this PR only headers are supported |
Got it, so this unlocks a use case like useplunk. |
Yes, though I'm planning a small launch with all those features requested so webhook forms would make more sense to users. |
Btw you should try to post something to https://docs.useplunk.com/api-reference/contacts/subscribe to see if we are still missing something there |
Ref #4093 #3871
Here added new resource control for out properties. It is replaced action and method properties webhook form. Now users will be able to additionally provide headers. In another PR headers will let user to customize body format.
Also migrated "action" in existing webhook forms to resource prop type.