Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Canvas resize on Linux #4310

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix: Canvas resize on Linux #4310

merged 1 commit into from
Oct 19, 2024

Conversation

istarkov
Copy link
Member

Description

https://discord.com/channels/955905230107738152/1297002444647170129/1297002444647170129

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from kof October 19, 2024 09:03
@istarkov istarkov merged commit 32615ba into main Oct 19, 2024
15 checks passed
@istarkov istarkov deleted the f-ix-linux branch October 19, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants