Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: a new global root icon #4298

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: a new global root icon #4298

merged 1 commit into from
Oct 17, 2024

Conversation

kof
Copy link
Member

@kof kof commented Oct 17, 2024

Description

To symbolize global settings we are changing the icon

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from istarkov October 17, 2024 07:47
@kof kof merged commit 0f39f7e into main Oct 17, 2024
15 checks passed
@kof kof deleted the root-icon branch October 17, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istarkov istarkov istarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @istarkov