New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix multiline expression #4297

Merged

istarkov merged 1 commit into main from fix-expr

Oct 16, 2024

Member

istarkov commented Oct 16, 2024

Description

What is this PR about (link the issue and add a short description)

Steps for reproduction

click button
expect xyz

Code Review

hi @kof, I need you to do
- conceptual review (architecture, feature-correctness)
- detailed review (read every line)
- test it on preview

Before requesting a review

made a self-review
added inline comments where things may be not obvious (the "why", not "what")

Before merging

tested locally and on preview environment (preview dev login: 5de6)
updated test cases document
added tests
if any new env variables are added, added them to .env file


          Fix expression

1f31001

istarkov requested review from kof and johnsicili

October 16, 2024 11:22

kof approved these changes

View reviewed changes

istarkov merged commit 2337551 into main

15 checks passed

istarkov deleted the fix-expr branch

October 16, 2024 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet