Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show custom option in easing dropdow only when used #4290

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

JayaKrishnaNamburu
Copy link
Contributor

fixes #4197

Description

This PR improves the UX for custom option in the easing functions. Currently it is displaying every time, with the PR we show them only when value added by the users are custom and hides it when the entered value doesn't come under custom category.

Steps for reproduction

  • Add a transition on a node and then select a value from the dropdown.
  • When the dropdown is open and the easing that is added is a valid one. The Custom option should be hidden.
  • When a custom value is added under the text-area, then the select box should show Custom value.
Screen.Recording.2024-10-15.at.12.37.09.PM.mov

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit b07b904 into main Oct 16, 2024
15 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the custom-easing-function branch October 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom easing transition not working
2 participants