Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix expression editor decoration #4261

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Fix expression editor decoration #4261

merged 2 commits into from
Oct 11, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Oct 10, 2024 •
edited
Loading

Description

2 bugs

Click on test broke decoration

image
image

Symbols after decoration broke decoration

image
image

Would be good to improve

Error messages:

image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov merged commit 4ee045f into main Oct 11, 2024
15 checks passed
@istarkov istarkov deleted the deco branch October 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istarkov @TrySound