Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin page #27

Merged
merged 10 commits into from
Aug 5, 2023
Merged

feat: plugin page #27

merged 10 commits into from
Aug 5, 2023

Conversation

irubido
Copy link
Collaborator

@irubido irubido commented Apr 26, 2023

added plugins, details fetched from npm,
for now only "@chainsafe/web3.js-chainlink-plugin" on the list,
also fixed some bugs
Screenshot 2023-04-25 at 13 29 49

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2dc15d
Status: ✅  Deploy successful!
Preview URL: https://f2055907.web3js-landing.pages.dev
Branch Preview URL: https://irubido-plugins-page.web3js-landing.pages.dev

View logs

@mpetrunic
Copy link
Contributor

@irubido Note:

  • while plugins are loading, footer jumps up (it should stay at the bottom)
  • I don't think we should fetch plugin list for npm (plugin list should be hardcoded in json file)
  • We should be able to mark certain plugins as featured (should be highlighted and on top of the page)

@irubido
Copy link
Collaborator Author

irubido commented Aug 3, 2023

@irubido Note:

  • while plugins are loading, footer jumps up (it should stay at the bottom)
  • I don't think we should fetch plugin list for npm (plugin list should be hardcoded in json file)
  • We should be able to mark certain plugins as featured (should be highlighted and on top of the page)

Added JSON with pluginList, only plugin details are fetched from npm, if fetch fails, shows plugin names from JSON and failed to fetch details text.
Plugin sorted by isFeatured flag from JSON.

Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic mpetrunic merged commit f14ea68 into main Aug 5, 2023
2 checks passed
@mpetrunic mpetrunic deleted the irubido/plugins_page branch August 5, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants