Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add exports field #8119

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat(cli): add exports field #8119

merged 2 commits into from
Oct 15, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 15, 2024

Summary

  • Add exports field to the @rspack/cli package, align with @rspack/core and @rspack/dev-server.
  • Use sort-package-json to sort the package.json file.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Oct 15, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8abae17
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670e07d2cb58510008dbe2d7

@hardfist
Copy link
Contributor

what will consume @rspack/cli js API?

@chenjiahan chenjiahan changed the title feat(CLI): add exports field feat(cli): add exports field Oct 15, 2024
@chenjiahan
Copy link
Member Author

@hardfist Only a few public API, such as defineConfig and definePlugin:

// rspack.config.ts
import { defineConfig } from '@rspack/cli';

I add the exports field to prevent the internal modules of @rspack/cli from being mistakenly consumed by users.

@chenjiahan chenjiahan merged commit 0d01456 into main Oct 15, 2024
29 checks passed
@chenjiahan chenjiahan deleted the rslib_rspack_cli_1015 branch October 15, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants