Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid extra runtime for get javascript chunk filename #8099

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: avoid extra runtime for get javascript chunk filename #8099

merged 1 commit into from
Oct 14, 2024

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Oct 13, 2024

Summary

Align with webpack: https://github.com/webpack/webpack/blob/e7121fe9972b182832d401cabaf9d5ca489b1713/lib/RuntimePlugin.js#L286

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 13, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d40102
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670c0cc0b501f80008273f73

LingyuCoder
LingyuCoder approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LingyuCoder LingyuCoder merged commit a5b74a0 into web-infra-dev:main Oct 14, 2024
34 checks passed
@inottn inottn deleted the fix/runtime branch October 14, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inottn @LingyuCoder