Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source map is not works with Sentry #8080

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: source map is not works with Sentry #8080

merged 1 commit into from
Oct 10, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Oct 10, 2024

Summary

Fix: #7914

Relative: #7914

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5f4b3e7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670742dadf5ef00008dd1eef

@SyMind SyMind marked this pull request as ready for review October 10, 2024 02:59
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test case to avoid source map regression?

@SyMind
Copy link
Member Author

SyMind commented Oct 10, 2024

@chenjiahan There is a test case in swc. I don't think we should add related test cases in Rspack because this is a matter for swc.

But I'm releasing a canary version for Rspack to give users the opportunity to check.

@SyMind
Copy link
Member Author

SyMind commented Oct 10, 2024

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Oct 10, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ✅ success
devserver ✅ success

@SyMind SyMind merged commit e4f78d9 into main Oct 10, 2024
66 checks passed
@SyMind SyMind deleted the fix-source-map branch October 10, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The source map is not working on Sentry
3 participants