Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should support chunk.contentHash in PathData of compilation.getPath #8074

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Oct 9, 2024

Summary

Should render [contenthash] with combining chunk.contentHash and contentHashType in PathData of compilation.getPath

  • Add contentHashType to PathData
  • Use pathData.chunk.contentHash[pathData.contentHashType] instead when pathData.contentHash is None
  • Need to pass the output.hashDigestLength to render of filename template which need it to generate final contentHash strings

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cc80397
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67074defc0fba70009fdb374

@LingyuCoder LingyuCoder merged commit ab9c645 into main Oct 10, 2024
29 checks passed
@LingyuCoder LingyuCoder deleted the fix/path-data-chunk-contenthash branch October 10, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants