Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): be compitable to ts5.6 #8071

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(type): be compitable to ts5.6 #8071

merged 1 commit into from
Oct 9, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 9, 2024 •
edited
Loading

Summary

related to TS5.6 breaking changes
https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#iterator-helper-methods

fix when using skipLibCheck: false

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7aaef45
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67063cca502dfe000873c248

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 9, 2024
chenjiahan
chenjiahan approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@chenjiahan chenjiahan changed the title chore(type): be compitable to ts5.6 fix(type): be compitable to ts5.6 Oct 9, 2024
@chenjiahan chenjiahan merged commit e7792c7 into main Oct 9, 2024
33 checks passed
@chenjiahan chenjiahan deleted the test branch October 9, 2024 08:45
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

@SoonIter SoonIter

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan