fix: generate params of runtime module

web-infra-dev · Sep 26, 2024 · cb8ac9d · cb8ac9d
1 parent 917cd92
commit cb8ac9d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 7 deletions.
diff --git a/packages/rspack/etc/api.md b/packages/rspack/etc/api.md
@@ -14639,7 +14639,7 @@ export class RuntimeModule {
  // (undocumented)
  fullHash: boolean;
  // (undocumented)
- generate(compilation: Compilation): string;
+ generate(): string;
  // (undocumented)
  identifier(): string;
  // (undocumented)

diff --git a/packages/rspack/src/RuntimeModule.ts b/packages/rspack/src/RuntimeModule.ts
@@ -23,7 +23,7 @@ export class RuntimeModule {
  return {
  name: module.name,
  stage: module.stage,
- generator: () => module.generate(compilation),
+ generator: module.generate.bind(module),
  cacheable: !(module.fullHash || module.dependentHash),
  isolate: module.shouldIsolate()
  };
@@ -67,7 +67,7 @@ export class RuntimeModule {
  return true;
  }
 
- generate(compilation: Compilation): string {
+ generate(): string {
  throw new Error(
  `Should implement "generate" method of runtime module "${this.name}"`
  );

diff --git a/website/docs/en/api/javascript-api/compilation.mdx b/website/docs/en/api/javascript-api/compilation.mdx
@@ -439,7 +439,8 @@ module.exports = {
  super('custom');
  }
 
- generate(compilation) {
+ generate() {
+ const compilation = this.compilation;
  return `
  __webpack_require__.mock = function() {
  // ...

diff --git a/website/docs/en/api/plugin-api/compilation-hooks.mdx b/website/docs/en/api/plugin-api/compilation-hooks.mdx
@@ -616,7 +616,8 @@ module.exports = {
  super('custom');
  }
 
- generate(compilation) {
+ generate() {
+ const compilation = this.compilation;
  return `
  __webpack_require__.mock = function(file) {
  return ${RuntimeGlobals.publicPath} + "/subpath/" + file;

diff --git a/website/docs/zh/api/javascript-api/compilation.mdx b/website/docs/zh/api/javascript-api/compilation.mdx
@@ -439,7 +439,8 @@ module.exports = {
  super('custom', RuntimeModule.STAGE_NORMAL);
  }
 
- generate(compilation) {
+ generate() {
+ const compilation = this.compilation;
  return `
  __webpack_require__.mock = function() {
  // ...

diff --git a/website/docs/zh/api/plugin-api/compilation-hooks.mdx b/website/docs/zh/api/plugin-api/compilation-hooks.mdx
@@ -617,7 +617,8 @@ module.exports = {
  super('custom');
  }
 
- generate(compilation) {
+ generate() {
+ const compilation = this.compilation;
  return `
  __webpack_require__.mock = function(file) {
  return ${RuntimeGlobals.publicPath} + "/subpath/" + file;