Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host_talent and contributors fields to credits trait #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edziegle
Copy link

5 years ago, a proposal was accepted to add host_talent and contributors to the credits trait for video content. However, this was never formally implemented. This PR intends to finally correct that.

@edziegle
Copy link
Author

See #191

@calexicoz
Copy link
Collaborator

Howdy.

This looks ok, but every change to the ANS schema requires changing the ANS version. Can you do this:

https://github.com/washingtonpost/ans-schema#creating-a-new-ans-version

Once the new version has been created, there is an internal release process to go through to make it available to use.

Thanks!

@edziegle
Copy link
Author

Howdy.

This looks ok, but every change to the ANS schema requires changing the ANS version. Can you do this:

https://github.com/washingtonpost/ans-schema#creating-a-new-ans-version

Once the new version has been created, there is an internal release process to go through to make it available to use.

Thanks!

Should I go ahead and move this into the current dev version, or just make a 0.10.12?

@calexicoz
Copy link
Collaborator

Should I go ahead and move this into the current dev version, or just make a 0.10.12?

This needs to be a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants