Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: binopt #4281

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Conversation

HodanPlodky
Copy link
Collaborator

What I did

Started reimplementing the binary operation optimization and some additional from original pipeline to venom pipeline

How I did it

The optimization are done in the AlgebraicOptimizationPass since the types of optimizations nicely slots into the purpose of the pass. Most of the logic is directly taken from the original pipeline

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@HodanPlodky HodanPlodky changed the title Feat/binopt feat[venom]: binopt Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 12.93706% with 249 lines in your changes missing coverage. Please review.

Project coverage is 47.92%. Comparing base (b3ea663) to head (372317c).

Files with missing lines Patch % Lines
vyper/venom/passes/algebraic_optimization.py 12.76% 246 Missing ⚠️
vyper/venom/analysis/dfg.py 33.33% 2 Missing ⚠️
vyper/venom/__init__.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b3ea663) and HEAD (372317c). Click for more details.

HEAD has 127 uploads less than BASE
Flag BASE (b3ea663) HEAD (372317c)
138 11
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4281       +/-   ##
===========================================
- Coverage   91.40%   47.92%   -43.48%     
===========================================
  Files         112      112               
  Lines       15927    16204      +277     
  Branches     2694     2747       +53     
===========================================
- Hits        14558     7766     -6792     
- Misses        935     7824     +6889     
- Partials      434      614      +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HodanPlodky HodanPlodky marked this pull request as ready for review October 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants