Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: function inliner #4266

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 30, 2024

What I did

depends #4039

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

vyper/venom/passes/function_inliner.py Fixed Show fixed Hide fixed
vyper/venom/passes/function_inliner.py Fixed Show fixed Hide fixed
return ret

@property
def _threshold(self):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
inst.operands = [self._alloca_map[alloca_id].output]
if inst.opcode == "param":
inst.opcode = "store"
op = invoke_inst.operands[-i-1]

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable op is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants