generated from vvo/javascript-library-template
-
-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(time zones): better city grouping and renaming
This commit adds a better city information in simplified-time-zones.json file. Previously we were only taking cities from America/Los_Angeles (= Los Angeles) and then trying to find them back in geonames dataset. Then we would only merge cities if they both belonged to the exact same offsets + dst. Now we still only group cities from same country, same offset + dst, but we do so by first selecting all cities from geonames for this country + offset and then merging them. This means we now display things like `Pacific Time, Los Angeles, San Diego`. + added `mainCities` field as an array + added `alternativeName` (Pacific Time instead of America/Los_Angeles) BREAKING CHANGES: + renamed `timeZoneName` to `name` in simplified-time-zones.json + removed cities-with-time-zones.json from package and repository, it changes too often and would trigger many releases. This computation is better stored in Algolia or any other search engine if you need to search in it
- Loading branch information
Showing
8 changed files
with
420 additions
and
24,964 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
dist/ | ||
cities-with-time-zones.json | ||
simplified-time-zones.json | ||
time-zones-names.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,5 @@ | |
!*.yml | ||
/coverage/ | ||
/dist/ | ||
cities-with-time-zones.json | ||
time-zones-names.json | ||
simplified-time-zones.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.