Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete retries #358

Merged
merged 4 commits into from
May 10, 2023
Merged

Add delete retries #358

merged 4 commits into from
May 10, 2023

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented May 10, 2023

Description

The tests were failing because of the VPC not being fully detached from a load balancer before the delete command was issued. Essentially, the load balancers are too slow to shutdown and delete so the VPC remains in an attached state when the delete command is sent by Terraform. This PR does two things to help in the case that a VPC is attached to a load balancer:

  • When deleting, issue an update against a load balancer to detach the VPC
  • Add a retry on the VPC resource to check the error returned from the API and re-issue the delete command after a short wait.

Related Issues

Closes #355
A similar solution might work for #348

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@mondragonfx mondragonfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Delete on VPC with attached resources happens too quickly
2 participants