Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetcher/fedora): fix archive version #395

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Jun 13, 2024

What did you implement:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

before

$ goval-dictionary fetch fedora 37
INFO[06-13|14:38:55] start fetch data from repomd.xml of non-modular package 
INFO[06-13|14:38:55] Fetching...                              URL=https://dl.fedoraproject.org/pub/fedora/linux/updates/37/Everything/x86_64/repodata/repomd.xml
Failed to fetch files. err: fetchEverythingFedora. err: Failed to fetch feed file, err: Failed to fetch. err: [Failed to HTTP GET. url: https://dl.fedoraproject.org/pub/fedora/linux/updates/37/Everything/x86_64/repodata/repomd.xml, response: &{Status:404 Not Found StatusCode:404 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Content-Length:[196] Content-Security-Policy:[default-src 'none'; img-src 'self'] Content-Type:[text/html; charset=iso-8859-1] Date:[Thu, 13 Jun 2024 05:38:55 GMT] Referrer-Policy:[same-origin] Server:[Apache] Strict-Transport-Security:[max-age=31536000; preload] X-Content-Type-Options:[nosniff] X-Frame-Options:[DENY] X-Xss-Protection:[1; mode=block]] Body:0xc000134080 ContentLength:196 TransferEncoding:[] Close:false Uncompressed:false Trailer:map[] Request:0xc000120000 TLS:0xc0001380b0}]

$ goval-dictionary fetch fedora 38
INFO[06-13|14:51:34] start fetch data from repomd.xml of non-modular package 
INFO[06-13|14:51:34] Fetching...                              URL=https://dl.fedoraproject.org/pub/fedora/linux/updates/38/Everything/x86_64/repodata/repomd.xml
Failed to fetch files. err: fetchEverythingFedora. err: Failed to fetch feed file, err: Failed to fetch. err: [Failed to HTTP GET. url: https://dl.fedoraproject.org/pub/fedora/linux/updates/38/Everything/x86_64/repodata/repomd.xml, response: &{Status:404 Not Found StatusCode:404 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Content-Length:[196] Content-Security-Policy:[default-src 'none'; img-src 'self'] Content-Type:[text/html; charset=iso-8859-1] Date:[Thu, 13 Jun 2024 05:51:35 GMT] Referrer-Policy:[same-origin] Server:[Apache] Strict-Transport-Security:[max-age=31536000; preload] X-Content-Type-Options:[nosniff] X-Frame-Options:[DENY] X-Xss-Protection:[1; mode=block]] Body:0xc00043b200 ContentLength:196 TransferEncoding:[] Close:false Uncompressed:false Trailer:map[] Request:0xc0003ad9e0 TLS:0xc0001522c0}]

after

$ goval-dictionary fetch fedora 37 38
...
INFO[06-13|14:54:08] 263 Advisories for Fedora 38 Fetched 
INFO[06-13|14:54:08] 269 Advisories for Fedora 37 Fetched 
INFO[06-13|14:54:08] 269 CVEs for Fedora 37. Inserting to DB 
INFO[06-13|14:54:08] Refreshing...                            Family=fedora Version=37
INFO[06-13|14:54:08] Inserting new Definitions... 
269 / 269 [--------------------------------------------------------------------------------------------] 100.00% ? p/s
INFO[06-13|14:54:08] Finish                                   Updated=269
INFO[06-13|14:54:08] 263 CVEs for Fedora 38. Inserting to DB 
INFO[06-13|14:54:08] Refreshing...                            Family=fedora Version=38
INFO[06-13|14:54:08] Inserting new Definitions... 
263 / 263 [--------------------------------------------------------------------------------------------] 100.00% ? p/s
INFO[06-13|14:54:09] Finish                                   Updated=263

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Jun 13, 2024
@MaineK00n MaineK00n requested a review from shino June 13, 2024 05:49
Copy link
Contributor

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@MaineK00n MaineK00n merged commit 4a0eebf into master Jun 13, 2024
13 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/fetch-fedora branch June 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants