Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models/amazon): add time layout for 2023 #389

Merged
merged 1 commit into from
May 17, 2024

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

add another time layout for fetching amazon linux 2023

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

before

$ goval-dictionary fetch amazon 2023
INFO[05-08|06:58:59] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/mirrors/latest/x86_64/mirror.list
INFO[05-08|06:59:00] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/guids/1418ab6fdc77352962b566b68d128e69ae0855c9a970f3355ca67ca576c60fee/x86_64/repodata/repomd.xml
INFO[05-08|06:59:00] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/guids/1418ab6fdc77352962b566b68d128e69ae0855c9a970f3355ca67ca576c60fee/x86_64/repodata/updateinfo.xml.gz
INFO[05-08|06:59:00] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/mirrors/latest/x86_64/mirror.list
INFO[05-08|06:59:01] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/guids/0883b668627f61841ff737854834416e26d69ead212d4b6754e46b132f4016f6/x86_64/repodata/repomd.xml
INFO[05-08|06:59:01] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/guids/0883b668627f61841ff737854834416e26d69ead212d4b6754e46b132f4016f6/x86_64/repodata/updateinfo.xml.gz
WARN[05-08|06:59:01] Failed to parse string                   timeformat="[2006-01-02 15:04]" target string="2023-02-17 20:41:00"
WARN[05-08|06:59:01] Failed to parse string                   timeformat="[2006-01-02 15:04]" target string="2023-02-22 23:22:00"
...
WARN[05-08|06:59:01] Failed to parse string                   timeformat="[2006-01-02 15:04]" target string="2023-12-06 07:53:00"
INFO[05-08|06:59:01] Refreshing...                            Family=amazon Version=2023
INFO[05-08|06:59:01] Inserting new Definitions... 
625 / 625 [--------------------------------------------------------------------------------------------] 100.00% ? p/s
INFO[05-08|06:59:01] Finish                                   Updated=625

after

$ goval-dictionary fetch amazon 2023
INFO[05-08|07:00:51] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/mirrors/latest/x86_64/mirror.list
INFO[05-08|07:00:52] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/guids/1418ab6fdc77352962b566b68d128e69ae0855c9a970f3355ca67ca576c60fee/x86_64/repodata/repomd.xml
INFO[05-08|07:00:52] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/core/guids/1418ab6fdc77352962b566b68d128e69ae0855c9a970f3355ca67ca576c60fee/x86_64/repodata/updateinfo.xml.gz
INFO[05-08|07:00:52] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/mirrors/latest/x86_64/mirror.list
INFO[05-08|07:00:53] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/guids/0883b668627f61841ff737854834416e26d69ead212d4b6754e46b132f4016f6/x86_64/repodata/repomd.xml
INFO[05-08|07:00:53] Fetching...                              URL=https://cdn.amazonlinux.com/al2023/kernel-livepatch/guids/0883b668627f61841ff737854834416e26d69ead212d4b6754e46b132f4016f6/x86_64/repodata/updateinfo.xml.gz
INFO[05-08|07:00:53] Refreshing...                            Family=amazon Version=2023
INFO[05-08|07:00:53] Inserting new Definitions... 
625 / 625 [--------------------------------------------------------------------------------------] 100.00% 2601457 p/s
INFO[05-08|07:00:53] Finish                                   Updated=625

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n requested a review from shino May 7, 2024 22:03
@MaineK00n MaineK00n self-assigned this May 7, 2024
Copy link
Contributor

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@MaineK00n MaineK00n merged commit 19f5fcf into master May 17, 2024
13 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/amazon-time-layout branch May 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants