Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-sitemap): add sitemap plugin #37

Merged
merged 21 commits into from
Jan 30, 2024
Merged

feat(plugin-sitemap): add sitemap plugin #37

merged 21 commits into from
Jan 30, 2024

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jan 29, 2024 •
edited
Loading

  • sitemap plugin
  • sitemap plugin docs
  • related e2e tests
  • add it in theme-default

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Jan 29, 2024 •
edited
Loading

The plugin code is ready and it would be great if you can review it. @nruffing

I believe most of the code should be nice and clean, excerpt for the ensureHostName function. Suggestions how to improve the code are welcomed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7710700419

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.055%
Totals Coverage Status
Change from base Build 7708747392: 0.0%
Covered Lines: 279
Relevant Lines: 362
💛 - Coveralls

@Mister-Hope Mister-Hope merged commit 267f388 into main Jan 30, 2024
31 checks passed
@Mister-Hope Mister-Hope deleted the sitemap branch January 30, 2024 15:13
Mister-Hope added a commit that referenced this pull request Feb 13, 2024
@Mister-Hope
fix(theme-default): fix link active status, close #37
506e28c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nruffing nruffing Awaiting requested review from nruffing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mister-Hope