Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with ESLint v9 #2331

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Improve compatibility with ESLint v9 #2331

merged 2 commits into from
Nov 29, 2023

Conversation

ota-meshi
Copy link
Member

This PR changes to not use APIs scheduled for removal in ESLint v9.

See https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/

@FloEdelmann
Copy link
Member

Are the replacements available in all ESLint versions we support? See also #2166 where we can drop support for ESLint v7.

@ota-meshi
Copy link
Member Author

Yes, I think we can support up to ESLint v6.2 for now.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then 🙂

One small (non-blocking) wish: Could you add a GitHub CI job with ESLint v9?

@ota-meshi
Copy link
Member Author

Unfortunately, ESLint v9 has not even been released in alpha version yet 😓 We can add tests once it is released.

@ota-meshi ota-meshi merged commit 7b7b4ce into master Nov 29, 2023
15 checks passed
@ota-meshi ota-meshi deleted the compat-v9 branch November 29, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants