Fix edge cases in PostgreSQL maintenance #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two separate issue with the PostreSQL maintenance script. Both are related to waiting for the upgrade to complete. * Fixes a panic in case we receive an event with an SGDbOps without any conditions * Fixes an issue where the script will run repack prematurely, in case there is an event on a different, completed, SGDbOps in the namespace.
zugao
reviewed
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two separate issue with the PostreSQL maintenance script. Both are related to waiting for the upgrade to complete.
The second point is fairly theoretical, but the second one can be reproduced locally, even though it does not seem to occur in production. Probably a timing issue.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog