Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom pg exporter queries #250

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Remove custom pg exporter queries #250

merged 1 commit into from
Oct 28, 2024
+0 −560

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Oct 28, 2024

Summary

  • After upgrading stackgres operator to the latest version some of our custom pg metrics we export does not work anymore.. We have found out that the pg_exporter has been updated in stackgres as we don't require any of the metrics I removed in this PR

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@zugao zugao added the patch label Oct 28, 2024
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team October 28, 2024 08:25
@vshnbot vshnbot mentioned this pull request Oct 28, 2024
Merged
3 tasks
Kidswiss
Kidswiss approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test before rolling out

@zugao
Copy link
Collaborator Author

zugao commented Oct 28, 2024 •
edited
Loading

I tested with @wejdross and it seems the default config map was successfully recreated for each instances without any restarts. During maintenance the instances will pick up the new file.

@zugao zugao merged commit aee154d into master Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

@wejdross wejdross wejdross approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zugao @Kidswiss @wejdross