Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initcontainer to wait for PostgreSQL #247

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Oct 22, 2024

Summary

It was possible that Nextcloud started without PostgreSQL being ready. This new initcontainer will make sure that PostgreSQL is reachable before attempting to start the main Nextcloud container.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

It was possible that Nextcloud started without PostgreSQL being ready.
This new initcontainer will make sure that PostgreSQL is reachable
before attempting to start the main Nextcloud container.
@Kidswiss Kidswiss added the patch label Oct 22, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team October 22, 2024 09:04
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's good that we prevent from deploying nextcloud before postgres is available.

@Kidswiss Kidswiss merged commit 358271f into master Oct 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants