Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backups if Redis TLS is disabled #242

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix backups if Redis TLS is disabled #242

merged 1 commit into from
Oct 14, 2024

Conversation

TheBigLee
Copy link
Member

Summary

  • This PR fixes a bug, where the backups didn't work if Redis TLS is disabled.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee added bug Something isn't working patch labels Oct 14, 2024
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team October 14, 2024 08:11
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBigLee TheBigLee merged commit 88cb04c into master Oct 14, 2024
8 checks passed
@TheBigLee TheBigLee deleted the fix/redis_backup branch October 14, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants