-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add billing to services #240
Conversation
d34246b
to
8bf3da6
Compare
7d030bf
to
7be3a42
Compare
build is also failing and needs to be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the failing build action
b1695ff
to
e8b5a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code won't work if we have multiple deployments/statefullsets in single instance namespace, but that was never in acceptance criteria, therefore I'll aproove that.
This is exactly the reason why this PR exists, to filter other deployments/statefulsets. Currently we have 2 deployments for nextcloud, one for the service itself and one for the metrics and with current code we count nextcloud twice into billing. I understand that in the future other deployments and statefulsets might reside into the instance namespace that HAVE to be counted towards billing but this is not the case right now and we should never implement something for the future as we don't know how it will look like from requirements point of view. Update: the point is simple, we cannot know which statefulsets/deployments must be billed, metrics - no, collabora - yes, X no or yes? this has to be done when a new deployment/staefulset is added. |
8d33a34
to
7af8dfe
Compare
7af8dfe
to
2814d7b
Compare
Summary
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog