Add support for custom VMware attributes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VMware API has options for custom attributes. This is often used to configure IP-Addresses or ssh keys inside of a VM. This code extension allows users to provide a hash with all required data.
|
I've no idea how to add tests for this, but I use this in production for two weeks and it works fine. |
ekohl
approved these changes
May 21, 2024
Comment on lines
+76
to
+83
| additionalExtraConfig = if host['extraConfig'] | ||
| host['extraConfig'].map do |key, value| | ||
| { key: key, value: value } | ||
| end | ||
| else | ||
| [] | ||
| end | ||
| extraConfig = [{ key: 'guestinfo.hostname', value: host['vmhostname'] }] + additionalExtraConfig |
There was a problem hiding this comment.
Is this easier to read?
Suggested change
| additionalExtraConfig = if host['extraConfig'] | |
| host['extraConfig'].map do |key, value| | |
| { key: key, value: value } | |
| end | |
| else | |
| [] | |
| end | |
| extraConfig = [{ key: 'guestinfo.hostname', value: host['vmhostname'] }] + additionalExtraConfig | |
| extraConfig = [{ key: 'guestinfo.hostname', value: host['vmhostname'] }] | |
| if host['extraConfig'] | |
| extraConfig += host['extraConfig'].map do |key, value| | |
| { key: key, value: value } | |
| end | |
| end |
I also wonder what happens if guestinfo.hostname is in host['extraConfig'].
Makes me tempted to write:
extraConfig = { 'guestinfo.hostname' => host['vmhostname'] }
extraConfig.merge(host['extraConfig']) if host['extraConfig']And later:
extraConfig: extraConfig.map { |k, v| { key: k, value: v } }
|
@bastelfreak want to change it some more, or just merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMware API has options for custom attributes. This is often used to configure IP-Addresses or ssh keys inside of a VM. This code extension allows users to provide a hash with all required data.